[crypto] improve API descriptions for HMAC and KMAC #21197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadephilipoom
approved these changes
Feb 6, 2024
Signed-off-by: Ryan Torok <[email protected]>
RyanTorok
force-pushed
the
hmac-kmac-doc-fixes
branch
from
c2e1f20 to
d1f3c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a couple misleading API descriptions in cryptolib:
HMAC: Correct the description to say that the caller must set the tag size to be the size of the output of the hash function they are using, not always 32 bytes.
KMAC: Clarify the key sizes that are supported.