[provisioning] fix bugs in FT personalization binary to prepare for certificate generation #20923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
reviewed
Jan 23, 2024
pamaury
approved these changes
Jan 23, 2024
KMAC must be configured properly for the keymgr to advance. Additionally, this erases the flash info pages that store certificitates before they are written to (to ensure we always start from a clean slate). Signed-off-by: Tim Trippel <[email protected]>
The bazel rule must add the basename of the autogenerated files, not the pathname. Signed-off-by: Tim Trippel <[email protected]>
A SHA256 hash is 32 bytes, not 20. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
ft-perso-certgen
branch
from
c4b6c2e to
8c1f607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several bugs in the FT personalization binary and certificate template generation infrastructure.