Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[topgen,Makefile] Remove code generated by topgen #20922

Closed
wants to merge 1 commit into from

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Jan 22, 2024

The clkmgr, pin_mux, and rstmgr have their reg_top and reg_pkg generated by topgen, so the corresponding files in their hw/ip directory are unnecessary.
There is no use to have hw/Makefile handle these IPS either.

The clkmgr, pin_mux, and rstmgr have their reg_top and reg_pkg
generated by topgen, so the corresponding files in their hw/ip
directory are unnecessary.
There is no use to have hw/Makefile handle these IPS either.

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem requested a review from msfschaffner as a code owner January 22, 2024 20:31
@matutem matutem requested a review from rswarbrick January 22, 2024 20:32
@matutem
Copy link
Contributor Author

matutem commented Jan 23, 2024

This is problematic unless modules are ipgen, so it is not worth doing now. Closing this.

@matutem matutem closed this Jan 23, 2024
@matutem matutem deleted the makefile_cleaning branch January 23, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant