[rv_dm,dv] Remove TODOs when setting reset values in env cfgs #20919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TODOs were reminding us to verify that the numbers are right. They are! The values are stored in the hartinfo array in rv_dm.sv, which gets initialised with DebugHartInfo (defined a few lines earlier). This has reset values that match the DV code. Signed-off-by: Rupert Swarbrick <[email protected]>
marnovandermaas
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TODOs were reminding us to verify that the numbers are right. They are! The values are stored in the hartinfo array in rv_dm.sv, which gets initialised with DebugHartInfo (defined a few lines earlier). This has reset values that match the DV code.