[dv,usbdev] Type fixes for xcelium testing #20918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce type casts required for strong typing with xcelium. Use enum types not strings within usdbev_smoke_vseq. Signed-off-by: Adrian Lees <[email protected]>
jdonjdon
reviewed
Jan 22, 2024
| @@ -48,7 +48,7 @@ class usbdev_smoke_vseq extends usbdev_base_vseq; | |||
| csr_update(ral.avbuffer); | |||
| endtask | |||
|
|
|||
| task call_token_sequence(input string pkt_type, input string pid_type); | |||
| task call_token_sequence(input pkt_type_e pkt_type, input pid_type_e pid_type); | |||
There was a problem hiding this comment.
Good catch @alees24,
apart from strong typing, I think this wouldn't pass even in vcs.
There was a problem hiding this comment.
It certainly wouldn't have been behaving as intended, but sadly is syntactically permissible according to the specification, given that vcs is not enforcing strong typing rules. It ended up loading the raw bytes from the string literal into the 'm_pid_type' enum variable!
jdonjdon
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minimal changes to the recently-introduced usbdev_smoke test to achieve the same behavior whichever simulation tool is used.
Introduce type casts required for strong typing with xcelium.
Use enum types not strings within usdbev_smoke_vseq; attempting to use run-time strings to identify the different enumeration values does not work, and unfortunately does not result in a build error because the strings are treated as open arrays of bytes and subject to bit-streaming casts.