Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RV_DM]rv_dm_mem_tl_access_halted_vseq #20911

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[RV_DM]rv_dm_mem_tl_access_halted_vseq #20911

merged 1 commit into from
Jan 22, 2024

Conversation

BasitMehmood
Copy link
Contributor

This commit contains some slightly changes in data_type r_data.

@BasitMehmood
[RV_DM]rv_dm_mem_tl_access_halted_vseq
d4732a4 
This commit contains some slightly changes in data_type r_data.

Signed-off-by: Basit Mehmood <[email protected]>
@BasitMehmood BasitMehmood requested a review from a team as a code owner January 22, 2024 09:34
@BasitMehmood BasitMehmood requested review from rswarbrick and removed request for a team January 22, 2024 09:34
@BasitMehmood
Copy link
Contributor Author

@rswarbrick. Kindly review it. Thanks

rswarbrick
rswarbrick approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, r_data probably makes more sense for something that's we only read. Looks good to me.

@rswarbrick rswarbrick merged commit 48cb2e2 into lowRISC:master Jan 22, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BasitMehmood @rswarbrick