[edn/dv] Fix failing tests #20897
Merged
[edn/dv] Fix failing tests #20897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2024 14:04
This commit fixes a failing genbits test. The test sequence was waiting for the SM to reach the Idle state but the SM was already in SWPortMode. This caused a timeout. Now the sequence waits for SWPortMode instead, which is effectively the same since the SM has to go into Idle before it can enter the SWPortMode. Signed-off-by: Hakim Filali <[email protected]>
This commit raises the test timeout for the edn_disable test from 100_000 ns to 500_000 ns. While debugging some failing tests from the regression I came across some failures for the edn_disable test. These tests were failing because the test timeout was too low. Signed-off-by: Hakim Filali <[email protected]>
h-filali
requested review from
eshapira and
vogelpi
and removed request for
a team and
eshapira
vogelpi
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes some failing tests.
For further information check out the individual commit messages.