[lib/base] Move crc32 from silicon_creator to lib/base.
#20892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Philipoom <[email protected]>
After moving the CRC32 library out of `silicon_creator`, replace references to it with the new location and fix include guards and BUILD files. Signed-off-by: Jade Philipoom <[email protected]>
moidx
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the cryptolib and test framework to use CRC32 utilities without pulling in a dependency on
silicon_creator. Since the CRC32 library didn't have anysilicon_creatordependencies, this was just a matter of updating references to the library so they point to the new location.Looking at this for #19173