[crypto] Pass buffers by value. #20891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadephilipoom
force-pushed
the
pass-buffers-by-value
branch
3 times, most recently
from
0c0f251 to
e102b33
Compare
jadephilipoom
force-pushed
the
pass-buffers-by-value
branch
from
e102b33 to
23a952e
Compare
jrvanwhy
reviewed
Jan 22, 2024
| * | ||
| * The order of `data` and `len` is important here for Rust compatibility; if | ||
| * `data` comes first, the representation exactly matches slices and is easier | ||
| * to call from Rust. |
There was a problem hiding this comment.
It's possible that the current compiler implementation always puts data first, but the layout of slices is not guaranteed, so that's not something we can rely on.
There was a problem hiding this comment.
I see, that's a shame. I'll remove the comment.
Since word/byte buffers are structs containing only a pointer and a length, there is no need to make them pointers when they are return values, and this makes the API a little more ergonomic. Signed-off-by: Jade Philipoom <[email protected]>
This is helpful for compatibility when the cryptolib is called from Rust code. Signed-off-by: Jade Philipoom <[email protected]>
Signed-off-by: Jade Philipoom <[email protected]>
Now that the output buffer is passed by value, the length must be returned separately. Signed-off-by: Jade Philipoom <[email protected]>
jadephilipoom
force-pushed
the
pass-buffers-by-value
branch
from
7a8de7d to
bd00104
Compare
jrvanwhy
approved these changes
Jan 24, 2024
moidx
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since word/byte buffers are structs containing only a pointer and a length, there is no need to make them pointers when they are return values, and this makes the API more ergonomic and easier to call from Rust (since you can just pass a slice directly). I also fixed the order of
dataandlenin the buffer types for Rust compatibility in the second commit. The third commit applies the same change to hash digest structs (which look a lot like word buffers except they remember the hash mode used to construct them).