[prim_trivium] Allow dynamically disabling the lockup protection #20885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the lockup protection could only be disabled statically at compile time, which is less suitable in practice as it should only be allowed in very few corner cases. Signed-off-by: Pirmin Vogel <[email protected]>
This was referenced Jan 18, 2024
msfschaffner
approved these changes
Jan 18, 2024
|
The kokoro failure is unrelated - merging. |
cdgori
reviewed
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the lockup protection could only be disabled statically at compile time, which is less suitable in practice as it should only be allowed in very few corner cases.
Factored out of #20852 to unblock some other work.