[sca] Acknowledge command for aes_serial_batch_alternative_encrypt #20786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Rozic <[email protected]>
vrozic
requested review from
HU90m,
vogelpi and
a team
and removed request for
a team and
HU90m
nasahlpa
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks @vrozic! Do you think that we also need this acknowledgment in the new uJSON code as well as in ot-sca for uJSON?
|
I am merging this. The CI failure is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command acknowledgement to
aes_serial_batch_alternative_encryptfunction inaes_serial.c