[tests,chip_rstmgr] Fix comments in rstmgr_sw_rst_ctrl_test #20767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matutem
requested review from
jadephilipoom and
jdonjdon
and removed request for
a team
matutem
force-pushed
the
fix_rstmgr_test
branch
from
3c4dc79 to
ccb9347
Compare
rswarbrick
approved these changes
Jan 7, 2024
| * controls peripheral reset as follows: | ||
| * There are 8 RSTMGR.SW_RST_CTRL_N registers, one of which corresponds | ||
| * to USB_AON, which has no software writeable CSRs, so it is not amenable | ||
| * to this test. The other registers controls peripheral reset as follows: |
There was a problem hiding this comment.
Nit: I think you now want "control" here.
The comment should refer to the 8 bits in the SW_RST_CTRL_N CSR. Add a reset for USB_AON ahead of all others with the lame epectation that the test still passes. Signed-off-by: Guillermo Maturana <[email protected]>
matutem
force-pushed
the
fix_rstmgr_test
branch
from
ccb9347 to
39f17a2
Compare
|
The failure of e2e_bootstrap_rma_fpga_cw310_rom_with_fake_keys and spi_device_smoketest_fpga_cw310_test_rom are completely unrelated, so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment should refer to the 8 bits in the SW_RST_CTRL_N CSR.