Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sival,envs] Remove redundant fpga_cw310_sival_rom_ext #20759

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Jan 4, 2024

This environment is included in EARLGREY_TEST_ENVS.

@matutem matutem requested review from moidx and jwnrt January 4, 2024 06:25
Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @matutem

Out of interest, are there any errors with defining an environment twice?

@matutem
Copy link
Contributor Author

matutem commented Jan 4, 2024

@jwnrt there should be no problem, since they are collected in a python dictionary. This was purely to thin things out.

This environment is included in EARLGREY_TEST_ENVS.

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem merged commit ae2a524 into lowRISC:master Jan 4, 2024
32 checks passed
@matutem matutem deleted the ibex_nmi_test branch January 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants