-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RV_DM] rv_dm_sba_debug_disabled_vseq #20739
Closed
shahid-mehmod
wants to merge
1
commit into
lowRISC:master
from
shahid-mehmod:rv_dm_sba_debug_disabled
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright lowRISC contributors. | ||
// Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
class rv_dm_sba_debug_disabled_vseq extends rv_dm_sba_tl_access_vseq; | ||
`uvm_object_utils(rv_dm_sba_debug_disabled_vseq) | ||
|
||
`uvm_object_new | ||
|
||
constraint lc_hw_debug_en_c { | ||
lc_hw_debug_en == lc_ctrl_pkg::On; | ||
} | ||
constraint scanmode_c { | ||
scanmode == prim_mubi_pkg::MuBi4False; | ||
} | ||
|
||
task sba_access(); | ||
csr_wr(.ptr(jtag_dmi_ral.dmcontrol.dmactive), .value(1)); | ||
req = sba_access_item::type_id::create("req"); | ||
randomize_req(req); | ||
cfg.debugger.sba_access(req); | ||
endtask | ||
|
||
task body(); | ||
repeat ($urandom_range(1, 10)) begin | ||
sba_access(); | ||
cfg.clk_rst_vif.wait_clks($urandom_range(0, 1000)); | ||
cfg.rv_dm_vif.lc_hw_debug_en = get_rand_lc_tx_val(.t_weight(0), .f_weight(1), .other_weight(4)); | ||
Check warning on line 28 in hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv GitHub Actions / verible-verilog-lint[verible-verilog-lint] hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv#L28
Raw output
|
||
sba_access(); | ||
`DV_CHECK_EQ(req.is_err, SbaErrNone) | ||
end | ||
endtask : body | ||
endclass : rv_dm_sba_debug_disabled_vseq |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely sure I understand this. I think the previous code was dying with an error if we saw an SBA access that wasn't expected. Your patch demotes this to uvm_info / UVM_HIGH and makes it happen less often (checking
lc_hw_debug_en
).We definitely should not make this change without some careful thought and explanatory comments.