[crypto] Implement HKDF. #20725
Merged
[crypto] Implement HKDF. #20725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HKDF is a common HMAC-based KDF separate from KDF-CTR. This PR implements it on top of the existing HMAC interface. Signed-off-by: Jade Philipoom <[email protected]>
moidx
approved these changes
Dec 22, 2023
|
I'll merge this quickly so that I can open the follow-up with a test, but if you have any comments @y-srini I'm happy to make follow-up changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HKDF is a common HMAC-based KDF separate from KDF-CTR. This PR implements it on top of the existing HMAC interface.
HKDF wasn't originally part of the cryptolib API because (I think) there was some confusion about whether it was the same thing as KDF-CTR with HMAC as the PRF. It's a bit different, though, and more commonly used, so it seems worth its own entrypoint.