Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoreboard #20712

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Scoreboard #20712

merged 2 commits into from
Dec 22, 2023

Conversation

Saad-Anees1
Copy link
Contributor

[usbdev] usbdev scoreboard

this PR contains integration of predictor in usbdev scoreboard

@jdonjdon

This request contains classes of usbdev predictor with little ammendment

Signed-off-by: Saad Anees <[email protected]>
@Saad-Anees1 Saad-Anees1 requested a review from a team as a code owner December 21, 2023 13:20
@Saad-Anees1 Saad-Anees1 requested review from eshapira and removed request for a team December 21, 2023 13:20
@Saad-Anees1 Saad-Anees1 force-pushed the scoreboard branch 2 times, most recently from 83ace93 to cbca4e9 Compare December 21, 2023 15:18
@Saad-Anees1
Copy link
Contributor Author

@jdonjdon why these checks are failing.

@jdonjdon
Copy link
Contributor

@jdonjdon why these checks are failing.

023-12-21T15:56:37.7543331Z * Error-[SFCOR] Source file cannot be opened has 1 failures:
2023-12-21T15:56:37.7543659Z * Test cover_reg_top has 1 failures.
2023-12-21T15:56:37.7543930Z * cover_reg_top
2023-12-21T15:56:37.7544402Z Line 1262, in log /azp/agent/_work/1/s/scratch/HEAD/usbdev-sim-vcs/cover_reg_top/build.log
2023-12-21T15:56:37.7544643Z
2023-12-21T15:56:37.7545029Z Error-[SFCOR] Source file cannot be opened
2023-12-21T15:56:37.7545378Z Source file "usbdev_packetiser.sv" cannot be opened for reading due to 'No
2023-12-21T15:56:37.7545700Z such file or directory'.
2023-12-21T15:56:37.7545989Z Please fix above issue and compile again.
2023-12-21T15:56:37.7546306Z "../src/lowrisc_dv_usbdev_env_0.1/usbdev_env_pkg.sv", 56

This happens due to "usbdev_packetiser.sv" is not added to
https://github.com/lowRISC/opentitan/blob/master/hw/ip/usbdev/dv/env/usbdev_env.core

@jdonjdon jdonjdon self-requested a review December 21, 2023 16:48
@jdonjdon
Copy link
Contributor

@jdonjdon why these checks are failing.

023-12-21T15:56:37.7543331Z * Error-[SFCOR] Source file cannot be opened has 1 failures: 2023-12-21T15:56:37.7543659Z * Test cover_reg_top has 1 failures. 2023-12-21T15:56:37.7543930Z * cover_reg_top 2023-12-21T15:56:37.7544402Z Line 1262, in log /azp/agent/_work/1/s/scratch/HEAD/usbdev-sim-vcs/cover_reg_top/build.log 2023-12-21T15:56:37.7544643Z 2023-12-21T15:56:37.7545029Z Error-[SFCOR] Source file cannot be opened 2023-12-21T15:56:37.7545378Z Source file "usbdev_packetiser.sv" cannot be opened for reading due to 'No 2023-12-21T15:56:37.7545700Z such file or directory'. 2023-12-21T15:56:37.7545989Z Please fix above issue and compile again. 2023-12-21T15:56:37.7546306Z "../src/lowrisc_dv_usbdev_env_0.1/usbdev_env_pkg.sv", 56
This happens due to "usbdev_packetiser.sv" is not added to https://github.com/lowRISC/opentitan/blob/master/hw/ip/usbdev/dv/env/usbdev_env.core

It's means i have to add other classes as well that involved in usbdev predictor. or just i have to add usbdev_packetiser.sv?

Add usbdev_packetiser.sv to usbdev_env.core

@Saad-Anees1
Copy link
Contributor Author

@jdonjdon it's still failing.

@jdonjdon
Copy link
Contributor

@Saad-Anees1
Copy link
Contributor Author

@jdonjdon it's still failing.

I am not sure how this is pass on your end. CI fails because usb20_item declared as abstract (https://cs.opensource.google/opentitan/opentitan/+/master:hw/dv/sv/usb20_agent/usb20_item.sv;drc=5309af625e402327f8f6ff95cbe3bb0477226960;l=12)

you need to remove virtual keyword from (https://cs.opensource.google/opentitan/opentitan/+/master:hw/dv/sv/usb20_agent/usb20_item.sv;drc=5309af625e402327f8f6ff95cbe3bb0477226960;l=12)

Another PR was done by @MubashirSaleem775 yesterday in which virtual keyword was removed.
But that PR is still under review.

this request contains integration of predictor in usbdev scoreboard
class.

Signed-off-by: Saad Anees <[email protected]>
@Saad-Anees1
Copy link
Contributor Author

Saad-Anees1 commented Dec 22, 2023

Thanks @jdonjdon
Now all checks are passing.

@Saad-Anees1 Saad-Anees1 requested a review from jdonjdon December 22, 2023 05:39
@jdonjdon jdonjdon merged commit d385e4c into lowRISC:master Dec 22, 2023
31 checks passed
@Saad-Anees1 Saad-Anees1 deleted the scoreboard branch December 26, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants