Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usbdev] Predictor of usbdev #20703

Closed

Conversation

sarahmazhar-impare
Copy link
Contributor

This request contains the usbdev_TransactionManager class of the usbdev predictor (reference model). Some amendments are done to make it compatible with the scoreboard.

@sarahmazhar-impare sarahmazhar-impare requested a review from a team as a code owner December 21, 2023 10:29
@sarahmazhar-impare sarahmazhar-impare requested review from jdonjdon and removed request for a team December 21, 2023 10:29
This request contains the usbdev_TransactionManager class of the usbdev
predictor (reference model). Some amendments are done to make it
compatible with the scoreboard.

Signed-off-by: sarahmazhar-impare <[email protected]>
Copy link
Contributor

@jdonjdon jdonjdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in line

@@ -67,7 +67,8 @@ class usbdev_TransactionManager extends uvm_object;
end
end
2: begin // wait for handshake Assuming HANDSHAKE packet is sent by the device as an ACK TODO
`uvm_info(get_type_name(),"ACK Handshake",UVM_LOW);
pid = 8'b0010_1101;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahmazhar-impare Is this pid is the same pid as in usb20_item.sv ?

Copy link
Contributor Author

@sarahmazhar-impare sarahmazhar-impare Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdonjdon Yes it is same as the usb20_item.sv pid for Ack type handshake

@jdonjdon jdonjdon self-requested a review December 22, 2023 00:27
Copy link
Contributor

@jdonjdon jdonjdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for #20709 merged and use the same enum defined
in usb20_agent_pkg in the PR.

@rswarbrick
Copy link
Contributor

Hi @sarahmazhar-impare! Is this PR still current? If so, please could you rebase it and we'll try to review it. If not, please could you close it?

@sarahmazhar-impare sarahmazhar-impare deleted the predictor branch March 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants