Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verible-lint] Pin version of verible instead of following latest #20697

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

a-will
Copy link
Contributor

@a-will a-will commented Dec 21, 2023

The verible github actions look for an Ubuntu-specific tarball in the releases, but these stopped being built. Use the latest release for which that tarball is available.

The verible github actions look for an Ubuntu-specific tarball in the
releases, but these stopped being built. Use the latest release for
which that tarball is available.

Signed-off-by: Alexander Williams <[email protected]>
@a-will
Copy link
Contributor Author

a-will commented Dec 21, 2023

Unfortunately, we don't get to see the effect of the action change in the PR run -- It has to be submitted first. But https://github.com/chipsalliance/verible/releases/tag/v0.0-3430-g060bde0f was the last one with the Ubuntu release that the action currently looks for.

We need chipsalliance/verible-actions-common#4 to be fixed to be able to use any later releases.

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this @a-will ! This will unblock many of us.

@a-will a-will merged commit a588f59 into lowRISC:master Dec 21, 2023
25 of 31 checks passed
@a-will a-will deleted the pin-verible-lint branch December 21, 2023 06:56
@tmichalak
Copy link

The underlying issue has been fixed in chipsalliance/verible-actions-common#5, so you can unpin the version.

@a-will
Copy link
Contributor Author

a-will commented Dec 21, 2023

The underlying issue has been fixed in chipsalliance/verible-actions-common#5, so you can unpin the version.

Thanks for the fix! We'll probably keep it pinned, though, so changes happen in CI at a reliable cadence. Having a floating tool version was a bug on our part, hehe.

However, the fixes to the actions do mean that we aren't blocked from upgrading by that incompatibility! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants