[sival] ROM_EXT PROD SIVAL Configuration #20694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-will
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Random thought: I wonder if it would be more git-friendly if we committed these in ihex or some other textual format and had bazel do the conversion to binary. I suppose we don't anticipate these to need to support diff, though /shrug
No need to bother for this PR, though!
There was a problem hiding this comment.
Hi @a-will, this is a good point. I think we should discuss this in the SW WG. We should consider doing this or alternatively, use something like lfs to manage binaries.
timothytrippel
approved these changes
Dec 21, 2023
Binary were built from commit f508590. Signed-off-by: Miguel Osorio <[email protected]>
This commit modifies the `silicon_owner_sival_rom_ext` execution environment to use a pre-built/signed rom_ext. Signed-off-by: Miguel Osorio <[email protected]>
This commit adds the ability to filter build and test targets by silicon execution environments. This is required given that the signing and DUT configurations are different for silicon_creator versus silicon_owner tests. Signed-off-by: Miguel Osorio <[email protected]>
moidx
force-pushed
the
sival-prod-sku
branch
from
a2f6a33 to
688eac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silicon_owner_sival_rom_extexecution environment to use the pre-built/signed binaries.