Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otp_ctrl,doc] Document scrambling keys being ephemeral if seed_valid=0 #20688

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Dec 20, 2023

In the past, there have been misunderstandings whether scrambling keys having seed_valid = 0 are safe to be used at all. As it turns out, they are. This PR adds this information to the interfaces section of the otp_ctrl documentation.

This resolves #13201.

In the past, there have been misunderstandings whether scrambling keys
having seed_valid = 0 are safe to be used at all. As it turns out, they
are. This commit adds this information to the interfaces section of the
otp_ctrl documentation.

This resolves lowRISC#13201.

Signed-off-by: Pirmin Vogel <[email protected]>
Copy link
Contributor

@msfschaffner msfschaffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @vogelpi, LGTM!

@vogelpi vogelpi merged commit 88508d8 into lowRISC:master Dec 21, 2023
30 of 31 checks passed
@vogelpi vogelpi deleted the doc-clarify-seed-valid branch December 25, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otbn] Check seed_valid bit of OTP scrambling interface
2 participants