[ot_certs] asn1 library unittest #20648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
jwnrt,
HU90m,
timothytrippel and
engdoreis
and removed request for
a team
pamaury
force-pushed
the
ot_certs-asn1_lib-unittest
branch
3 times, most recently
from
c9d0fca to
e6d0050
Compare
timothytrippel
approved these changes
Dec 14, 2023
nbdd0121
approved these changes
Jan 8, 2024
Remove duplicate comments, add a test for an empty tag. Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
ot_certs-asn1_lib-unittest
branch
from
e6d0050 to
650fe7a
Compare
|
I have rebased the PR since the last CI run was a month old, no other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unitest for the asn1 library.