Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated keymgr_dpe key derivation test #20608

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

rsahita
Copy link

@rsahita rsahita commented Dec 9, 2023

Updated keymgr_dpe key derivation test

@rsahita rsahita requested a review from a team as a code owner December 9, 2023 00:13
@rsahita rsahita requested review from engdoreis and moidx and removed request for a team December 9, 2023 00:13
@rsahita rsahita force-pushed the integrated_dev branch 2 times, most recently from 439e777 to 6dacd78 Compare December 11, 2023 21:13
Copy link
Contributor

@engdoreis engdoreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I left a code style comment below. Other than that LGTM.

sw/device/tests/keymgr_dpe_key_derivation_test.c Outdated Show resolved Hide resolved
@rsahita rsahita removed the request for review from dbeitel-opentitan January 4, 2024 16:58
@rsahita
Copy link
Author

rsahita commented Jan 4, 2024

@moidx - need some help to see why CI failed the last time (it had succeeded before) - can you PTAL and merge?

@moidx moidx closed this Jan 4, 2024
@moidx moidx reopened this Jan 4, 2024
@moidx
Copy link
Contributor

moidx commented Jan 4, 2024

Closing/re-opening PR to trigger CI run.

@moidx moidx merged commit edef349 into lowRISC:integrated_dev Jan 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants