[bazel] Convert sigverify_key_validity to the new rules. #20391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moidx
approved these changes
Nov 18, 2023
pamaury
approved these changes
Nov 20, 2023
cfrantz
force-pushed
the
bazel-e2e
branch
3 times, most recently
from
b42384c to
a53bc8d
Compare
1. Eliminate references to opentitan_functest(). 2. Eliminate explicit splices in favor of the implied universal splice. Signed-off-by: Chris Frantz <[email protected]>
Fixes: lowRISC#20098 Signed-off-by: Chris Frantz <[email protected]>
1. Prefer an OTP configuration to an explicit bitstream splice. 2. Do not run as a test_rom test. This test is not compatible with the test_rom because the test_rom does not respect the exec_disabled OTP config word. Signed-off-by: Chris Frantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up some comment references to
opentitan_functest().Fixes: #20098