Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash_ctrl] D2(S) Signoff #20977

Closed
msfschaffner opened this issue Jan 25, 2024 · 3 comments · Fixed by #21969
Closed

[flash_ctrl] D2(S) Signoff #20977

msfschaffner opened this issue Jan 25, 2024 · 3 comments · Fixed by #21969

Comments

@msfschaffner
Copy link
Contributor

msfschaffner commented Jan 25, 2024

Description

Ensure D2(S) signoff criteria are still maintained (this is not a focus area block).

@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Jan 25, 2024
@msfschaffner msfschaffner self-assigned this Jan 25, 2024
@msfschaffner msfschaffner changed the title [flash_ctrl] Title [flash_ctrl] D2 Signoff Jan 25, 2024
@msfschaffner msfschaffner changed the title [flash_ctrl] D2 Signoff [flash_ctrl] D2(S) Signoff Jan 25, 2024
@msfschaffner
Copy link
Contributor Author

msfschaffner commented Mar 8, 2024

Current head:

6d341ad09b

Commits since Earlgrey-ES tapeout

6d341ad09b[flash_ctrl,dv] fix constraint for mp_regions test - Test fix
1845e1b501 [flash_ctrl,dv] clean up interrupt mode test - Series of rtl change and dv sync: interrupt type update 3/3
54a1be8fe0 [flash_ctrl] Change FIFO interrupts to status type - Series of rtl change and dv sync: interrupt type update 2/3
b01fe839e7 [flash_ctrl] Bump version to 2.0.0 and revert D/V stages - Series of rtl change and dv sync: interrupt type update 1/3
296883d1df [flash_ctrl,dv] update flash_disable condition - Testbench update to fix flash_disable condition in sync with #20042
fff5337f51 [flash_ctrl/dv] Added big delay to phy_arb_redun test for some rare cases - Closed source test adjustment to add more delay
66b9cd97b9 [flash_ctrl/dv] Various fixes for xcelium - Strong type cast fix for xcelium
a5a0980b90 [flash_ctrl/dv] Simplify cov interface and remove NoSameAddrRead_A - coverage update
541f67a1c1 [flash_ctrl,dv] add missing covergroup for phy interface - Add cover group for phy interface
0dd29ab736 [lint,flash_ctrl] Fix some warnings and lint - fix test warning
0b5666989a [dv,flash_ctrl] Remove specific file reference in comment - Comment update
c721c51c13 [rtl, prim] Add 'commit' functionality to prim_count - prim_count ip update
61a237e197 [util/reggen] reverse order of substruct generation - make sv struct casting friendly
fc8484601e [reggen,hw] Create index parameter for registers windows - create fifo idx parameter
c939d9a6d5 [otp_ctrl] Add support for multiple HW_CFG partitions - tb update with a new otp hw_cfg format
ce648ca68e [ipgen.pwrmgr] Change core files to vlnv naming and label as virtual - pkg.core file update in sync to new tpl format
de31bdf1c2 [reggen] Remove the devmode input - remove obsolete port (devmode_if) and test bench update
963a5006cc [doc] Minor tweak to md sanitisation code - doc update
975a6eb927 [adc_ctrl,dv] Tidy up access to intr_state in env_cfg files - code cleanup
8fd8c5f12a [hw,flash_ctrl,rtl] Change disable register to RW1S - change register type
7f43378243 [flash_ctrl,dv] update expected double bit error set - test update
8b1a18ceef [flash_ctrl,dv] fix cs reg fail - fix closed source test failure
1b16ca2122 [reggen] Add mubi support SWAccess that sets/clears a reg - csr type change
abe2888fc3 [flash_ctrl,doc] fix format error - testplan update part 2/2
3451d3b85c [SiVal] Test plan update for flash_ctrl - testplan update part 1/2
7e8c5d5e23 [flash_ctrl,dv] add page number ot direct read task - debug print update in tb
34f9e5eeae [flash_ctrl,dv] fix phy_host_gran_err test - fix test failure
ca688e1ba1 [flash_ctrl,dv] fix rd_path integrity test - fix test failure
353a29813d [flash_ctrl,dv] fix cs phy_arb_redun test - fix test failure
9a3d1ae220 [flash_ctrl,dv] fix rand_ops test - fix test failure
272b036d20 [flash_ctrl,dv] fix cs flash_ctrl_derr_detect - fix test failure
eae7444e73 [flash_ctrl,dv] update path for block tb enable_small_rma - Add short rma feature to tb
59f8142826 [doc] Moved badges over to using hosted images - doc hyper link update
e04ce36b87 [flash_ctrl,dv] env update for new closed source tests - closed source tb supprot
607cf1d60f [flash_ctrl,dv] increase full mem access timeout - fix test failure
470140250b [flash_ctrl,dv] fix mid_op_rst test - fix test failure
19cc17de50 [flash_ctrl] selectively check op_status - fix test failure
bad351d71b [flash_ctrl,dv] fix hw_rma test - fix test failure
0f4c785d12 [flash_ctrl,dv] fix descramble address - fix test failure
e7843407ad [flash_ctrl,dv] hardening read path error injection - fix test failure
d75508fea5 [flash_ctrl,dv] update fast alert receiver - fix test failure
caa893d96e [flash_ctrl,dv] scb update for bank erase - fix test failure
00758f7c28 [flash_ctrl,dv] minor code clean up - code clean up
bc69dd720d [flash_ctrl,dv] fix wr_path_intg test - fix test failure
fedb2079d6 [flash_ctr,dv] fix eviction test - fix test failure
bfbbb0d86c [flash_ctrl,dv] Generate error integrity from random data - fix test failure
7123c0b792 [flash_ctrl,dv] Add calculate_expected_data impl - fix test failure
f291083319 [flash_ctrl,dv] add selective alert check for error tests - fix test failure
18eb300d15 [flash_ctrl,dv] Wait for op done - fix test failure
ab08634874 [flash_ctrl,dv] increase wait timeout - fix test failure
14cbc066bc [flash_ctrl,dv] update scoreboard memory with bank erase command - fix test failure
d1cda116a1 [flash_ctrl,dv] ignore small rma for error test - fix test failure
9d44e02dda [flash_ctrl,dv] fix lcmgr_intg test error - fix test failure
da84d9c103 [flash_ctrl,dv] cs small_rma support - Add small rma feature to closed source
ec3aa9a2ed [flash_ctrl,dv] enable scramble for all area - fix test failure
cfdb877085 [flash_ctrl,dv] minor tb adjustment - fix test failure
fe2604f8ef [flash_ctrl,dv] cs contraint fix - fix closed source test failure
d67e35d864 [reggen] Generate constants for only the main block - rtl: add prefix 'core' to main reg block
184ccab79e [flash_ctrl,dv] more tb cleanup for reset event - fix test failure
7688e714e8 [reggen] Add initial support for version and cip_id hjson fields - hjson update

Issue closed since the Earlgrey-ES tapeout

#21459 - sival test
#21458 - sival test
#21457 - sival test
#21456 - sival test
#21455 - sival test
#21454 - sival test
#21453 - sival test
#21452 - sival test
#21211 - rtl update for interrupt types
#20961 - diagnose fpga test failure
#19679 - spec cleanup among sw and hw sections
#19136 - rtl : parallelized rma ack from flash_ctrl and otbn to lc_ctrl. Done by #21267
#16636 - flash_ctrl tests are completed
#15783 - usability improvement. 2 items are addressed and 1 is dropped.

Currently open issues:

#21353 - firmware update for prod
#21225 - testplatform (fpga) update regarding #20961
#21637 - rtl update for Prod : reduce severity of ecc error
#20589 - fpga test failure: root caused and fix is suggested in #20961
#20194 - sival issue
#19595 - need sw update for prod
#18157 - doc improvement

Summary

We decided to fix the alert behavior #21637 at a later milestone.
The only RTL change that was relevant is the change of interrupt types in #21211, which is already tested in DV.
The block thus still fulfills D2S criteria.

@msfschaffner
Copy link
Contributor Author

@andreaskurth @vogelpi @GregAC PTAL

@andreaskurth
Copy link
Contributor

andreaskurth commented Mar 12, 2024

I agree that D2S is still fulfilled. I reviewed the following commits, which change flash_ctrl's RTL code, in detail (commit list obtained with git log --oneline Earlgrey-M2.5.2-RC0..HEAD -- hw/ip/flash_ctrl/rtl):

  • 54a1be8 [flash_ctrl] Change FIFO interrupts to status type
  • 0dd29ab [lint,flash_ctrl] Fix some warnings and lint
  • c721c51 [rtl, prim] Add 'commit' functionality to prim_count
  • 61a237e [util/reggen] reverse order of substruct generation
  • fc84846 [reggen,hw] Create index parameter for registers windows
  • de31bdf [reggen] Remove the devmode input
  • 8fd8c5f [hw,flash_ctrl,rtl] Change disable register to RW1S
  • 1b16ca2 [reggen] Add mubi support SWAccess that sets/clears a reg
  • fbd888e Revert "[reggen] Add CIP_IDs and bump all major versions"
  • 0ba10b3 [reggen] Add CIP_IDs and bump all major versions
  • e47df29 [misc] Use lc_tx_t testing functions at endpoints

The only significant RTL change here, as @msfschaffner described above, is the change of interrupt types. Thus IMO this is a block with minor changes and we can proceed with the move to D2S.

andreaskurth added a commit to andreaskurth/opentitan that referenced this issue Mar 12, 2024
This resolves lowRISC#20977.

Signed-off-by: Andreas Kurth <adk@lowrisc.org>
andreaskurth added a commit to andreaskurth/opentitan that referenced this issue Mar 12, 2024
This resolves lowRISC#20977.

Signed-off-by: Andreas Kurth <adk@lowrisc.org>
andreaskurth added a commit that referenced this issue Mar 12, 2024
This resolves #20977.

Signed-off-by: Andreas Kurth <adk@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants