Remove custom python override #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the python override is fixing the wrong problem. All module not found issue comes from the fact that `PATH` is overriden and wrong python3 binary is being used when a program is called from fusesoc. The change to `PATH` is caused by the python program wrapper, but in this case it's not necessary for fusesoc. Simply stopping wrapping fusesoc is enough to fix the issue.
hcallahan-lowrisc
approved these changes
Jan 2, 2024
|
This fix seems a bit subtle to me, so just wanted to leave some related items here about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the python override is fixing the wrong problem. All module not found issue comes from the fact that
PATHis overriden and wrong python3 binary is being used when a program is called from fusesoc.The change to
PATHis caused by the python program wrapper, but in this case it's not necessary for fusesoc. Simply stopping wrapping fusesoc is enough to fix the issue.