Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[rtl] Fix counter reset value on FPGA" #2229

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nasahlpa
Copy link
Member

@nasahlpa nasahlpa commented Dec 2, 2024

Reverts #2226 because the scope for counter_q is incorrect resulting in synthesis failure for Xilinx targets.

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vogelpi vogelpi added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 0945aa8 Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants