Skip to content

Commit

Permalink
[rtl] Fix logic for generating ECC related alerts
Browse files Browse the repository at this point in the history
Under certain circumstances Ibex ignored the ECC check from the register
file when it should not have. This fixes the issue.

Fixes #2188
  • Loading branch information
GregAC committed Jul 15, 2024
1 parent 6682336 commit 9e4a950
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rtl/ibex_core.sv
Original file line number Diff line number Diff line change
Expand Up @@ -916,8 +916,8 @@ module ibex_core import ibex_pkg::*; #(
assign rf_rdata_b = rf_rdata_b_ecc_i[31:0];

// Calculate errors - qualify with WB forwarding to avoid xprop into the alert signal
assign rf_ecc_err_a_id = |rf_ecc_err_a & rf_ren_a & ~rf_rd_a_wb_match;
assign rf_ecc_err_b_id = |rf_ecc_err_b & rf_ren_b & ~rf_rd_b_wb_match;
assign rf_ecc_err_a_id = |rf_ecc_err_a & rf_ren_a & ~(rf_rd_a_wb_match & rf_write_wb);
assign rf_ecc_err_b_id = |rf_ecc_err_b & rf_ren_b & ~(rf_rd_b_wb_match & rf_write_wb);

// Combined error
assign rf_ecc_err_comb = instr_valid_id & (rf_ecc_err_a_id | rf_ecc_err_b_id);
Expand Down

0 comments on commit 9e4a950

Please sign in to comment.