Nix update and cleanups #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcallahan-lowrisc
approved these changes
Dec 22, 2023
flake.nix
Outdated
| @@ -45,15 +42,12 @@ | |||
| # riscv-arch = "rv32imc"; | |||
| # }; | |||
|
|
|||
| pythonEnv = pkgs.python3.withPackages ( | |||
There was a problem hiding this comment.
To me it makes more sense to assemble python environments on a per-project basis, pulling in patched versions of dependencies from lowrisc-nix when needed. I don't really see the point of keeping the env itself in the common repo?
There was a problem hiding this comment.
I have converted the env to use poetry
flake.nix
Outdated
Comment on lines
122
to
123
| if [ -z "$DIRENV_IN_ENVRC" ]; then | ||
| cat <<'EOF' |
There was a problem hiding this comment.
Indentation look strange?
There was a problem hiding this comment.
Bash heredoc doesn't support indentation
* Removed verilator overlay. It's sufficient to add the dependencies to buildInputs * Remove unneeded comment and code * Use toolchain from lowrisc-nix
hcallahan-lowrisc
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #85