Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of read me #66

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

marnovandermaas
Copy link
Contributor

No real content changes, just minor reviews.

Copy link

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some extra nits from me (sorry), but this looks sensible.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@engdoreis
Copy link
Contributor

I don't know why rust linting decided to fail now, but to fix it you can run cargo fmt inside the rust folder and commit the changes.

@marnovandermaas
Copy link
Contributor Author

CI failures are unrelated to this PR, which are fixed here: #67
I'm merging these changes in the meantime.

@marnovandermaas marnovandermaas merged commit d642440 into lowRISC:main Oct 16, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants