Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default board, userInfo fix #286

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

ocdtrekkie
Copy link
Contributor

Here's attempt two to fix #284. The build repo for the Sandstorm package is at https://github.com/ocdtrekkie/whitebophir-sandstorm and it appears to work with the changes here.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting,
and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

@lovasoa lovasoa merged commit 1cd0dba into lovasoa:master Oct 26, 2023
3 checks passed
@lovasoa
Copy link
Owner

lovasoa commented Oct 26, 2023

Thank you, @ocdtrekkie !

@ocdtrekkie ocdtrekkie deleted the sandstorm-support branch October 26, 2023 17:48
@ocdtrekkie
Copy link
Contributor Author

Happy to be able to both build a nifty new Sandstorm package and contribute beneficially upstream. (Technically we just saved everyone an unneeded syscall during normal working conditions, I suppose.)

Now that this is merged, I should be able to use my packaging repo off it cleanly, so I'll finish up the metadata stuff and publish a final package soon.

@lovasoa
Copy link
Owner

lovasoa commented Oct 26, 2023

Most importantly, we added DEFAULT_BOARD, which I guess will be used even outside of sandstorm.

alex-brain pushed a commit to alex-brain/whitebophir that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note: There is now a Sandstorm package for this app!
2 participants