Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushover add UP/DOWN status sounds #5426

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sebastian-mora
Copy link

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #1953

Adds the ability to select Up and Down sounds for pushover notifications. As before if no/or of the options are selected then the device default sound is used.

To keep backwards compatibility I added notification.pushoversounds_up which is used if the heartbeat event is UP.

One note is the UP/DOWN text on the fields is not translated.

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.
I have left two review comments below and have added this to the v2.1 slot

server/notification-providers/pushover.js Show resolved Hide resolved
server/notification-providers/pushover.js Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Dec 12, 2024
@sebastian-mora
Copy link
Author

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushover different sound for up/down
2 participants