-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitor Type] Real Browser with Keyword & Iframe Support #4116
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Note that this conflicts with #3919. |
And duplicate code, which make it hard to maintain in the future. If I want to fix bug of this I have to fix it 2 times. Those new features in According to our pull request rules, we should have a discussion on how to design it first. |
Hi @bthurlow, any chance you can get into discussion with Louis ? I would really like to see that feature in Uptime Kuma. BR and thanks for your efforts |
@louislam If it suits you, once I can get back on this code base, I'll see about consolidating all the keyword code into a single method to make management and reuse much better. cc: @MarcAroni81 |
This comment was marked as spam.
This comment was marked as spam.
Extracting keyword and other checks is tracked in #3919 |
@bthurlow thanks for your work. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #4068
Adds a real browser keyword monitoring type that has the ability to examine the content of iframes while looking for the keyword.
Type of change
Checklist
Screenshots (if any)