Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved underscore from deps to devDeps as it was unused #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved underscore from deps to devDeps as it was unused #16

wants to merge 1 commit into from

Conversation

JamesMGreene
Copy link
Contributor

Fixes #7

@JamesMGreene
Copy link
Contributor Author

@louischatriot Please merge and publish a new release. Thank you!

@JamesMGreene
Copy link
Contributor Author

@louischatriot: (Please please please. This one is simple but important!)

@JamesMGreene JamesMGreene mentioned this pull request Aug 30, 2017
Open
@redoPop
Copy link

redoPop commented May 25, 2021

This PR resolves a high severity npm audit warning for consumers:

There's a high severity advisory for the version of underscore used in this lib. Applications inheriting that dependency are also subject to the warning. Moving underscore to devDeps puts those consumers in the clear.

@0x0a0d
Copy link

0x0a0d commented Jun 6, 2021

@louischatriot please merge this and #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move underscore from "dependencies" to "devDependencies".
3 participants
@JamesMGreene @redoPop @0x0a0d