Spotify Muting (part 2) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the volume of the app to 0 and unmuting by setting it to 100 (or whatever specified by user as the max). Tested only on SA, didn't add the functionality to III or VC. Yet. Also fixed a typo where the playerSet config didn't get saved as "Other"
… this there were no need for the Maximum Volume setting and users can set the volume whatever and this won't screw with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I made a new pull request since I dug around and found a method to actually mute the application in Mixer, not just change the volume)
Added a feature to mute/unmute Spotify in the Windows Volume Mixer. I wasn't familiar on how this software worked, so I copied the same method as in the Pause/Unpause hotkey function, and just switched it to mute the Spotify Application.
It gets the PIDs of "Spotify" named processes and uses CSCore to find the session with the Spotify's PID in a specific Audio Device Source. After that it just mutes/unmutes the Spotify application in the Mixer. I also added a Dropdown menu where the user selects the right Audio Device where Spotify is playing, if it happens to be something else than the Default Device.
I tested it for some time and it seems to work fine. I added it only to SA since that's what I'm playing currently and could reliably test.
Also there was a typo when it saved the preferences to the config file and it didn't save the "Other" selection:
else if (radioButtonVolume.Checked) Should have been (?):
else if (radioButtonOther.Checked)