Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Items type in array with schema annotation #49

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

losisin
Copy link
Owner

@losisin losisin commented Mar 11, 2024

Current behaviour is to read Items type only when array is not empty recursively from go types. Now it is possible to set Items type with schema annotation in comment. Useful when array is empty but want to control the types accepted in array.

closes #48

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (aefd9ff) to head (a6bc339).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +0.01%     
==========================================
  Files           6        6              
  Lines         325      328       +3     
==========================================
+ Hits          321      324       +3     
  Misses          2        2              
  Partials        2        2              
Flag Coverage Δ
unittests 98.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@losisin losisin merged commit 3c5f905 into main Mar 11, 2024
3 checks passed
@losisin losisin deleted the feature/set-items-type-in-array branch March 11, 2024 10:33
pascal-hofmann added a commit to pascal-hofmann/helm-values-schema-json that referenced this pull request Oct 24, 2024
The `items` annotation was added in losisin#49, but README.md was not updated.
pascal-hofmann added a commit to pascal-hofmann/helm-values-schema-json that referenced this pull request Oct 24, 2024
The `items` annotation was added in losisin#49, but README.md was not updated.
pascal-hofmann added a commit to pascal-hofmann/helm-values-schema-json that referenced this pull request Oct 24, 2024
The `item` annotation was added in losisin#49, but README.md was not updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for declaring items types in empty array
1 participant