Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new flag 'noAdditionalProperties' to add 'additionalProperties: false' to the generated JSON schema #39

Closed

Conversation

hajowieland
Copy link

@hajowieland hajowieland commented Feb 21, 2024

Implements #38

  • Introduces a new command-line flag noAdditionalProperties
  • Extended the Config for the new flag
  • Extended the Schema for additionalProperties to be added to all nodes
  • Update Usage section in README

@hajowieland hajowieland requested a review from losisin as a code owner February 21, 2024 10:14
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (361856d) 98.58% compared to head (7dcc68b) 97.90%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/parser.go 66.67% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   98.58%   97.90%   -0.68%     
==========================================
  Files           6        6              
  Lines         423      428       +5     
==========================================
+ Hits          417      419       +2     
- Misses          4        6       +2     
- Partials        2        3       +1     
Flag Coverage Δ
unittests 97.90% <80.00%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@losisin
Copy link
Owner

losisin commented Jun 5, 2024

closed in favour of #70 and #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants