undo default EnvironmentName, breaks config based Environment Name

loresoft · May 10, 2024 · 88f8364 · 88f8364
1 parent cf07573
commit 88f8364
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -23,7 +23,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -64,7 +64,7 @@ jobs:
         with:
           name: packages
           path: "${{env.BUILD_PATH}}"
-          
+
   deploy:
     runs-on: ubuntu-latest
     needs: build

diff --git a/src/XUnit.Hosting/TestApplicationFixture.cs b/src/XUnit.Hosting/TestApplicationFixture.cs
@@ -59,9 +59,9 @@ protected virtual IHost CreateHost()
     /// Creates the settings for constructing an Microsoft.Extensions.Hosting.HostApplicationBuilder.
     /// </summary>
     /// <returns>A new instance of <see cref="HostApplicationBuilderSettings"/></returns>
-    protected virtual HostApplicationBuilderSettings CreateBuilderSettings()
+    protected virtual HostApplicationBuilderSettings? CreateBuilderSettings()
     {
-        return new HostApplicationBuilderSettings { EnvironmentName = Environments.Development };
+        return null;
     }
 
     /// <summary>