create display name #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the demo code! This really helped me out. I had to sort out the UX for displaying a multi-model graph and came up with this change. It doesn't quite fit this demo, but thought I'd pass it along.
Display Name
For user experience, a "DisplayName" attribute is derived for all vertices by passing the dataframe column name to be displayed in the graph to the create_vertex_df function as display_name. The function pulls the attribute value from the dataframe by including it in the columns list in the following line of code. (Highlighted here because it was not included in any of the github examples.)