-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate min/max usd btc values with btb database #230
base: main
Are you sure you want to change the base?
Conversation
I didn't knew such table did exited. At what frequency the table is updated? |
We could run in a issue with that table. The values are set as hourly, daily and weekly entries. The hourly entry is keeps for 24 hours, daily for 28 days and weekly forever. |
Ho so it's not ideal you mean ? |
I think nothing is really ideal, but we can test can test it via paper trading. We have basically 3 kinds of conditions. The report are more or less the same in each fork. edeng/idkravitz/masa forks behaves the same with the tables. The only fork that is different is the tntwist |
And also I have a suggestion, depending on how often reports are updated, you can add the minUSD and maxUSD calculation from the DB to the report itself alongside total_usdt. That would negate the purge of DB hourly and weekly. Wouldn't this be ideal solution? |
That's not a bad idea at all |
And how easy/difficult is it to do so? Too much overhead in calculation times? Right now, how often you generate reports? (I will go through the report code when I get time, so I can avoid above questions next time :-p) |
I think it's enough to calculate the min/max USD every hour |
I would suggest to calculate min/max USD/BTC from Coin Value table. This allows fair and true calculation irrespective of number of bots running on a single binance account.