Issue 43: Dynamically added inputs do not take configuration from data-slider-* attributes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x slider values under the slider. Added demos. Themed with classes: scale, min-scale, and max-scale.
Link: loopj#43 Users were confused by documentation showing data-slider-* attributes as being the way to configure the slider. data-slider-* options were being processed by a visitor function that for each input created a settings object and invoked SimpleSlider with those settings. Moved the logic that created a settings object to SimpleSlider.loadDataSettings(). If SimpleSlider() is called this method will be invoked to create the settings from the data-slider-* attributes. If SimpleSlider(settings) is called it will not (settings will come from the object being passed).
|
Thanks for fixing. Huge time saver. |
|
👍 this is a great fix, can we get the merge? |
|
👍 |
kviktor
added a commit
to BME-IK/jquery-simple-slider
that referenced
this pull request
Sep 16, 2014
- merge pull request 45 from the original repo (Issue 43: Dynamically added inputs do not take configuration from data-slider-* attributes loopj#45) - add a disabled attr to the slider - remove auto init of sliders when dom is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logic from visitor method into SimpleSlider.loadDataSettings().
This method is called when an input is turned into a simple slider with ("#myinput").simpleSlider().
If the user passes in a settings object, those values will be used and the data-slider-* values will be ignored.