Add touch support #20
Conversation
If step is not defined, there is no effect. Otherwise, the step defines the resulting precision of the output values. For example, if step is 0.1, then the precision is to the tenths of a unit. If step is 0.01, then the precision is to the 1/100 of a unit. If step > 0, precision is set to a full unit.
Signed-off-by: Martin Koistinen <[email protected]>
|
Hmmm, obviously, I'm not doing this correctly. The only commits you need for this is 7923dce, the others are already in the pull-request queue as I've sent them earlier. |
|
You had issues with my pull request? I use it right now without issues - perhaps its newer version of jQuery? I am using Zepto. |
|
I think it was more of an issue getting it to merge. I'm not the best with Git (yet!) and since your code hadn't been merged into the master yet, I had to add your repo as remote to my repor then try to merge that way. I probably flubbed something up along the way, but regardless, it didn't work for me and it seemed the code could be simpler anyway. Also, you didn't have any CoffeeScript. I normally use normal JS, but this repo is use CS and I wanted to keep it that way. |
|
Hi all. I'm using the code for the slider and have it working nicely in a test page. But I need to get it working on touch devices. I see you've successfully produced a version for Coffee Script, is there any way of porting this to the normal .js file? Thanks for your help. |
|
Fantastic. Works like a dream. Thanks Martin, you're a star. On 20 Apr 2013, at 23:30, Martin Koistinen [email protected] wrote:
|
|
@swhinnem, I believe the highlight feature was added (3 months ago) to the core-codebase after I issued my Pull Request (4 months ago). @loopj, is this project accepting PRs? |
|
I took the latest version and the version mkoisttinen references above, and did a bit of splicing. The result is here: https://github.com/jeffedsell/jquery-simple-slider/blob/master/simple-slider.js It works in all the testing I've done so far. |
|
Yeah, its a shame you have to do that. I guess this repo isn't being updated. |
|
it's a shame this is not maintained :( Thanks a lot @mkoistinen ! |
Hi, I was getting impatient (read: pressure from my project), so I attempted to bring in the work @gregavola had done with touch-support. Unfortunately, I couldn't make it work, so I started afresh using an approach I've used in other projects before with success.
This time it seems to work well on iDevices. I don't have Android devices around, but I've heard that this works on them too.
At any rate, it works! I've also added some simple adjustments to the CSS for touch-devices—namely, made the knob larger so you can actually touch it. =)