Merge pull request #446 from marioestradarosa/bool-type-fix

Fix boolean type (#325)
loopbackio · May 29, 2021 · f80ffe8 · f80ffe8
2 parents c5e72db + f821541
commit f80ffe8
Show file tree

Hide file tree

Showing 3 changed files with 6,001 additions and 1 deletion.
diff --git a/lib/mysql.js b/lib/mysql.js
@@ -435,7 +435,10 @@ MySQL.prototype.fromColumnValue = function(prop, val) {
         }
         break;
       case 'Boolean':
-        val = Boolean(val);
+        // BIT(1) case: <Buffer 01> for true and <Buffer 00> for false
+        // CHAR(1) case: '1' for true and '0' for false
+        // TINYINT(1) case: 1 for true and 0 for false
+        val = Buffer.isBuffer(val) && val.length === 1 ? Boolean(val[0]) : Boolean(parseInt(val));
         break;
       case 'GeoPoint':
       case 'Point':