Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix release.yaml for location of freeciv21-server.cmd #2440

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Bugfix release.yaml for location of freeciv21-server.cmd #2440

merged 2 commits into from
Nov 7, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Nov 7, 2024

Found releasing 3.1-rc.1

lmoureaux
lmoureaux approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, should we add the -f flag so it doesn't fail if the file isn't there?

@jwrober jwrober enabled auto-merge (rebase) November 7, 2024 21:46
@jwrober jwrober disabled auto-merge November 7, 2024 21:46
@jwrober
Copy link
Collaborator Author

jwrober commented Nov 7, 2024

While at it, should we add the -f flag so it doesn't fail if the file isn't there?

good call

@jwrober jwrober enabled auto-merge (rebase) November 7, 2024 21:49
@jwrober jwrober merged commit 87166a2 into longturn:master Nov 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwrober @lmoureaux