Send updated research after it is fully updated #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove a special case when there are no bulbs left to research (this shouldn't happen but did in longturn#2405) * Simplify setting an empty string for observers
Upon getting a free tech, the server was sending the updated research before it was done updating the struct. The client received contradicting information (in longturn#2405, that the tech was both fully researched and still the current tech goal). Closes longturn#2405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon getting a free tech, the server was sending the updated research before it was done updating the struct. The client received contradicting information (in #2405, that the tech was both fully researched and still the current tech goal).
Closes #2405.
Testing
I tested the following cases: