Clear warnings when loading Dagestan and Louisiana flags #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
changed the title
lmoureaux
force-pushed
the
bugfix/libpng-warning
branch
from
0714ee6
to
421a913
Compare
|
hm... not sure this fixes it... |
|
Which tileset are you using? |
|
I'm not even in game yet |
|
This is what is configured |
|
It probably says |
|
My Fedora 40 workstation is running libpng 12 |
The very next line after the second "invalid" shows this message So it still seems to be before tileset selection |
Dagestan flags were causing "libpng warning: bKGD: invalid" to be shown by the client. Produce a valid PNG with ImageMagick. Closes longturn#2291.
lmoureaux
force-pushed
the
bugfix/libpng-warning
branch
from
421a913
to
15f859f
Compare
|
Dagestan flags are now the only files causing the warnings for me (Louisiana has meanwhile been modified). I updated the PR accordingly. If you still see warnings could you apply the following patch and report the file names? diff --git a/client/tileset/sprite.cpp b/client/tileset/sprite.cpp
index d377e19fda..14d8f549e6 100644
--- a/client/tileset/sprite.cpp
+++ b/client/tileset/sprite.cpp
@@ -29,6 +29,7 @@ QPixmap *load_gfxfile(const char *filename)
if (QPixmapCache::find(QString(filename), entire)) {
return entire;
}
+ qCritical() << "Reading file" << filename;
entire->load(QString(filename));
QPixmapCache::insert(QString(filename), *entire);
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpng was complaining about "bKGD: invalid". Not sure what this means, but loading and saving with imagemagick fixed the issue.
Closes #2291.