Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker and Docker Compose support for the server #2051

Closed
wants to merge 1 commit into from

Conversation

nat-418
Copy link

@nat-418 nat-418 commented Nov 5, 2023

No description provided.

@nat-418 nat-418 marked this pull request as ready for review November 5, 2023 20:16
@lmoureaux
Copy link
Contributor

Hi nat! My first question is about your motivation. I'm not sure what the use case is: do you want this just for testing, or should this deployment handle saves, plugging in additional rulesets, doing user authentication? Should the client and modpack installer also work?

@nat-418
Copy link
Author

nat-418 commented Nov 6, 2023

Hi nat! My first question is about your motivation. I'm not sure what the use case is: do you want this just for testing, or should this deployment handle saves, plugging in additional rulesets, doing user authentication? Should the client and modpack installer also work?

I am thinking about self-hosting a server for me and some friends and noticed there was no Docker setup, and I figure that is the way most people are self-hosting their services these days so I decided to share my work on one. If there's anything you recommend I enable or configure let me know. I think I could pretty easily add a volume for saves and rulesets. Not sure exactly how the auth piece works if you want to explain. Basically, the container is just a simple Debian setup per what I saw in the README.

@lmoureaux
Copy link
Contributor

For the usage you describe I think it's important to have persistent saves and authentication support. (I suppose it's actually running on k8s? I don't think docker-compose is a good deployment method, would rather create a systemd service.) The ability to mount custom rulesets into the image would be nice but I don't see this as needed for a first iteration.

To facilitate maintenance, could we avoid hard-coding the server version?

Also I think the files should reside in dist/docker to avoid cluttering the repo root.

@lmoureaux lmoureaux marked this pull request as draft November 28, 2023 17:44
@lmoureaux
Copy link
Contributor

Closing as inactive - feel free to reopen if you come back to it

@lmoureaux lmoureaux closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants