feat(backing encryption): backing image encryption support #251
Conversation
|
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7051_backingimage_encryption_support
branch
2 times, most recently
from
0fd024b
to
8634f3f
Compare
Fixed. |
ChanYiLin
force-pushed
the
LH7051_backingimage_encryption_support
branch
from
8634f3f
to
eb5b2e4
Compare
|
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
|
@ChanYiLin Is it ready for review? |
Yes it is ready for review. |
pkg/sync/sync_file.go
Outdated
| if imgInfo.Format == "qcow2" { | ||
| tmpRawFile := fmt.Sprintf("%v-raw.tmp", sourceFile) | ||
| if err := util.ConvertFromQcow2ToRaw(sourceFile, tmpRawFile); err != nil { | ||
| return 0, errors.Wrapf(err, "failed to create raw image from qcow2 image %v", sourceFile) | ||
| } | ||
| // use the raw image as source when doing encryption | ||
| sourceFile = tmpRawFile | ||
| defer os.RemoveAll(tmpRawFile) | ||
| } |
There was a problem hiding this comment.
We don't have any progress for the image conversion, right?
Can we create a ticket for exposing the progress?
There was a problem hiding this comment.
Just wonder how do we get the progress of the conversion
if _, err := Execute([]string{}, QemuImgBinary, "convert", "-f", "qcow2", "-O", "raw", sourcePath, targetPath); err != nil {
return err
}
The conversion is part of the backing image preparation
But the current progress is about 100% data copying
how do we define and integrate the progress of conversion into data copying?
There was a problem hiding this comment.
A simple example
0-20%: image conversion
20-80%: encryption or decryption
ChanYiLin
force-pushed
the
LH7051_backingimage_encryption_support
branch
4 times, most recently
from
3bccfd1
to
a3e46ee
Compare
ChanYiLin
force-pushed
the
LH7051_backingimage_encryption_support
branch
from
a3e46ee
to
1b6e8bb
Compare
ref: longhorn/longhorn 7051 Signed-off-by: Jack Lin <[email protected]>
ChanYiLin
force-pushed
the
LH7051_backingimage_encryption_support
branch
from
1b6e8bb
to
dd3736d
Compare
ref: longhorn/longhorn#7051
Check the LEP here: longhorn/longhorn#8740