Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golangci-lint error #229

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: golangci-lint error #229

merged 1 commit into from
Apr 30, 2024

Conversation

FrankYang0529
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#7448

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

pkg/datasource/service.go Outdated Show resolved Hide resolved
pkg/manager/service.go Outdated Show resolved Hide resolved
Signed-off-by: PoAn Yang <[email protected]>
@FrankYang0529
Copy link
Contributor Author

All comments are addressed. Thank you.

@derekbit derekbit merged commit 2709238 into longhorn:master Apr 30, 2024
6 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-7448 branch April 30, 2024 03:36
@FrankYang0529
Copy link
Contributor Author

@mergify backport v1.6.x

Copy link

mergify bot commented May 13, 2024

backport v1.6.x

✅ Backports have been created

@FrankYang0529
Copy link
Contributor Author

@mergify backport v1.5.x

Copy link

mergify bot commented Jun 17, 2024

backport v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants