-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackingImage does not download URL correctly in some situation #182
Conversation
0357c13
to
45b6147
Compare
Testplan
This is the current state. The ISO is not downloaded properly.
|
45b6147
to
8dddb01
Compare
Remove the `Referer` header that is automatically added by the http client. Without this header it is possible to download files that are redirected several times. This mimics the behaviour of `curl` and `wget` which do not submit the `Referer` header by default. Signed-off-by: Volker Theile <[email protected]>
8dddb01
to
e5a5c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
Remove the
Referer
header that is automatically added by the http client. Without this header it is possible to download files that are redirected several times. This mimics the behaviour ofcurl
andwget
which do not submit theReferer
header by default.Which issue(s) this PR fixes:
longhorn/longhorn#7914
What this PR does / why we need it:
This PR removes the
Referer
header from the requests. This is necessary to allow downloads of files (e.g. ISO images) that are delivered from file hosters (e.g. SourceForge) via CDN which normally results in several redirects until the requested file is downloaded.This PR mimics the default behaviour of tools like
curl
orwget
.