Reduce unnecessary memory copying (#89)

longbridge · Aug 20, 2024 · 5d4b561 · 5d4b561
1 parent 4e21836
commit 5d4b561
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/crates/support/src/backend.rs b/crates/support/src/backend.rs
@@ -70,16 +70,15 @@ impl SimpleBackend {
     /// ```
     pub fn add_translations(&mut self, locale: &str, data: &HashMap<&str, &str>) {
         let data = data
-            .clone()
-            .into_iter()
-            .map(|(k, v)| (k.into(), v.into()))
+            .iter()
+            .map(|(k, v)| ((*k).into(), (*v).into()))
             .collect::<HashMap<_, _>>();
 
-        if let Some(trs) = self.translations.get_mut(locale) {
-            trs.extend(data.clone());
-        } else {
-            self.translations.insert(locale.into(), data.clone());
-        }
+        let trs = self
+            .translations
+            .entry(locale.into())
+            .or_insert(HashMap::new());
+        trs.extend(data);
     }
 }